Add poolID to Gateway AMM endpoints

[fengtality]

Why

AMM designs are getting more complex, and a simple QUOTE/BASE tuple may match multiple pools in protocols like Balancer. Similarly, other AMMs feature different fee settings for the same QUOTE/BASE pool. To allow users to specify which pools they are trading against, we need to specify the pool ID instead of these simple descriptors.

What

Add poolID as an optional parameter to the following Gateway endpoints below. Initially, the parameter is only required by AMMs like Balancer. For these AMMs, poolID should be used to fetch the right pool, not the other variables.

/amm/price
/amm/trade
/amm/liquidity/price
/amm/liquidity/add

Afterwards, add error-handling logic to inform users when poolID is missing, as well as unit tests.

Bounty

• Sponsor: Hummingbot Foundation
• Funding: Ethereum pot - see Connector Pots tab in HBOT Tracker
• Bounty amount: 500 USD or 167,000 HBOT (0.003 current price)
• Developer portion: 100%
• Status: OPEN

[vic-en]

I can work on this.

[webbdays]

if @vic-en drops
Please assign this to me. I will work on this.

[vic-en]

You can assign to @webbdays if he/she is really interested and can get it done.

[webbdays]

Thanks @vic-en

[webbdays]

/attempt

[webbdays]

Hi @fengtality, @nikspz
I have made an initial commit, which allows the user to pass poolID as req parameter.
If user don't pass it then error message will be sent in response.
But i don't have the domain knowledge on how to use the poolID further in the codebase.
Please guide.
Thanks.

[vic-en]

Hi @fengtality, @nikspz I have made an initial commit, which allows the user to pass poolID as req parameter. If user don't pass it then error message will be sent in response. But i don't have the domain knowledge on how to use the poolID further in the codebase. Please guide. Thanks.

I can give you some hints to help you get it done but I expect you to have an understanding of how to interract with smart contracts at the very least. Do you?

[webbdays]

I have some knowledge, previously used web3.js while i was learning to build a smart contract with local blockchain network using Ganache.
I have to revisit the concepts related to that.
I can understand what's happening with codebase with some guidance on the codebase.

[nikspz]

I have some knowledge, previously used web3.js while i was learning to build a smart contract with local blockchain network using Ganache. I have to revisit the concepts related to that. I can understand what's happening with codebase with some guidance on the codebase.

Did you reviewed / used Humminbot Client + Gateway codebase already?

[nikspz]

@webbdays Please be informed: Team shouldn't have to "hand hold" a dev through the process

[webbdays]

I am currently going through the code and docs. I will try mybest.
Hopely, i will deliver by this weekend. Thank you.

[nikspz]

hi @webbdays, upon discussion with the team we should assign this bounty to vic-en.

You could check one of the bounties here and leave comment if you want to be assigned:
hummingbot/hummingbot#6914
hummingbot/hummingbot#6898
hummingbot/hummingbot#6899

[nikspz]

#302 Assigned to @vic-en, please be informed:

• Since you’re assigned to this bounty exclusively, please keep us informed on your progress over the next few days
• Please review and follow contribution guidelines (https://hummingbot.org/developers/contributions/)
• Please review the checklist after PR submitted (https://hummingbot.org/developers/contributions/#checklist)
• Let us know if you don’t have time, and we will unassigned and keep it open for other devs
• Only one dev can be assigned to one bounty

Thanks for your contribution!

[webbdays]

Ok.

[nikspz]

Thanks for your participation, the bounty has been sent to @vic-en . The fix has been deployed on development branch and hummingbot version 1.27.0.