UniswapLP - Error adding liquidity #152

nikspz · 2023-07-11T03:56:51Z

Describe the bug

Error submitting ADD liquidity order to uniswapLP

Steps to reproduce

Clone and install latest development on Client + gateway
Create/start uniswapLP strategy
Review logs

Actual:
Liquidity is not added.
Call to https://localhost:15888/amm/liquidity/add failed

Release version

dev-1.18.0

Type of installation

Source

Attach required files

logs_conf_uniswap_v3_lp_arb.log
logs_gateway_app.log
UniswapLP-issue.zip

2023-07-11 03:47:29,207 - 160986 - hummingbot.strategy.uniswap_v3_lp.uniswap_v3_lp - INFO - Creating new position over 1783.8557719765 to 1971.6300637635 price range. [clock=2023-07-11 03:47:29+00:00]
2023-07-11 03:47:29,631 - 160986 - hummingbot.core.rate_oracle.rate_oracle - INFO - Network status has changed to NetworkStatus.CONNECTED. Starting networking...
2023-07-11 03:47:33,964 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - An unknown error has occurred on gateway. Please send your logs to dev@hummingbot.io
2023-07-11 03:47:33,964 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:33,965 - 160986 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/add failed. See logs for more details.
2023-07-11 03:47:33,965 - 160986 - GatewayEVMAMMLP - ERROR - Error submitting ADD liquidity order to uniswapLP on arbitrum_one for WETH-USDC.E 
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 436, in _add_liquidity
    order_result: Dict[str, Any] = await self._get_gateway_instance().amm_lp_add(
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 725, in amm_lp_add
    return await self.api_request("post", "amm/liquidity/add", request_payload)
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 218, in api_request
    raise e
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:33,967 - 160986 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1689047253.0, "order_id": "add-WETH-USDC.E-1689047249208333", "order_action": "LPType.ADD", "event_name": "RangePositionUpdateFailureEvent", "event_source": "uniswapLP_ethereum_arbitrum_one"}
2023-07-11 03:47:34,001 - 160986 - hummingbot.strategy.uniswap_v3_lp.uniswap_v3_lp - INFO - Creating new position over 1783.8557719765 to 1971.6300637635 price range. [clock=2023-07-11 03:47:34+00:00]
2023-07-11 03:47:38,631 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - An unknown error has occurred on gateway. Please send your logs to dev@hummingbot.io
2023-07-11 03:47:38,631 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:38,631 - 160986 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/add failed. See logs for more details.
2023-07-11 03:47:38,632 - 160986 - GatewayEVMAMMLP - ERROR - Error submitting ADD liquidity order to uniswapLP on arbitrum_one for WETH-USDC.E 
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 436, in _add_liquidity
    order_result: Dict[str, Any] = await self._get_gateway_instance().amm_lp_add(
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 725, in amm_lp_add
    return await self.api_request("post", "amm/liquidity/add", request_payload)
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 218, in api_request
    raise e
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:38,632 - 160986 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1689047258.0, "order_id": "add-WETH-USDC.E-1689047254001869", "order_action": "LPType.ADD", "event_name": "RangePositionUpdateFailureEvent", "event_source": "uniswapLP_ethereum_arbitrum_one"}
2023-07-11 03:47:39,192 - 160986 - hummingbot.strategy.uniswap_v3_lp.uniswap_v3_lp - INFO - Creating new position over 1783.8557719765 to 1971.6300637635 price range. [clock=2023-07-11 03:47:39+00:00]
2023-07-11 03:47:43,225 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - An unknown error has occurred on gateway. Please send your logs to dev@hummingbot.io
2023-07-11 03:47:43,225 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:43,226 - 160986 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/add failed. See logs for more details.
2023-07-11 03:47:43,226 - 160986 - GatewayEVMAMMLP - ERROR - Error submitting ADD liquidity order to uniswapLP on arbitrum_one for WETH-USDC.E 
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 436, in _add_liquidity
    order_result: Dict[str, Any] = await self._get_gateway_instance().amm_lp_add(
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 725, in amm_lp_add
    return await self.api_request("post", "amm/liquidity/add", request_payload)
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 218, in api_request
    raise e
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:43,226 - 160986 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1689047263.0, "order_id": "add-WETH-USDC.E-1689047259192714", "order_action": "LPType.ADD", "event_name": "RangePositionUpdateFailureEvent", "event_source": "uniswapLP_ethereum_arbitrum_one"}
2023-07-11 03:47:44,001 - 160986 - hummingbot.strategy.uniswap_v3_lp.uniswap_v3_lp - INFO - Creating new position over 1783.8557719765 to 1971.6300637635 price range. [clock=2023-07-11 03:47:44+00:00]
2023-07-11 03:47:50,807 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - An unknown error has occurred on gateway. Please send your logs to dev@hummingbot.io
2023-07-11 03:47:50,808 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:50,809 - 160986 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/add failed. See logs for more details.
2023-07-11 03:47:50,810 - 160986 - GatewayEVMAMMLP - ERROR - Error submitting ADD liquidity order to uniswapLP on arbitrum_one for WETH-USDC.E 
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 436, in _add_liquidity
    order_result: Dict[str, Any] = await self._get_gateway_instance().amm_lp_add(
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 725, in amm_lp_add
    return await self.api_request("post", "amm/liquidity/add", request_payload)
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 218, in api_request
    raise e
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:50,811 - 160986 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1689047270.0, "order_id": "add-WETH-USDC.E-1689047264001833", "order_action": "LPType.ADD", "event_name": "RangePositionUpdateFailureEvent", "event_source": "uniswapLP_ethereum_arbitrum_one"}
2023-07-11 03:47:51,209 - 160986 - hummingbot.strategy.uniswap_v3_lp.uniswap_v3_lp - INFO - Creating new position over 1783.8557719765 to 1971.6300637635 price range. [clock=2023-07-11 03:47:51+00:00]
2023-07-11 03:47:57,827 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - An unknown error has occurred on gateway. Please send your logs to dev@hummingbot.io
2023-07-11 03:47:57,828 - 160986 - hummingbot.core.gateway.gateway_http_client - NETWORK - Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:57,828 - 160986 - hummingbot.core.gateway.gateway_http_client - WARNING - Call to https://localhost:15888/amm/liquidity/add failed. See logs for more details.
2023-07-11 03:47:57,828 - 160986 - GatewayEVMAMMLP - ERROR - Error submitting ADD liquidity order to uniswapLP on arbitrum_one for WETH-USDC.E 
Traceback (most recent call last):
  File "/home/nikita/development/hummingbot/connector/gateway/amm_lp/gateway_evm_amm_lp.py", line 436, in _add_liquidity
    order_result: Dict[str, Any] = await self._get_gateway_instance().amm_lp_add(
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 725, in amm_lp_add
    return await self.api_request("post", "amm/liquidity/add", request_payload)
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 218, in api_request
    raise e
  File "/home/nikita/development/hummingbot/core/gateway/gateway_http_client.py", line 206, in api_request
    raise ValueError(f"Error on {method.upper()} {url} Error: {parsed_response}")
ValueError: Error on POST https://localhost:15888/amm/liquidity/add Error: {'message': 'Unknown error.', 'httpErrorCode': 503, 'errorCode': 1099, 'stack': 'Error: Request failed with status code 404\n    at createError (/home/nikita/gateway-dev/node_modules/axios/lib/core/createError.js:16:15)\n    at settle (/home/nikita/gateway-dev/node_modules/axios/lib/core/settle.js:17:12)\n    at IncomingMessage.handleStreamEnd (/home/nikita/gateway-dev/node_modules/axios/lib/adapters/http.js:269:11)\n    at IncomingMessage.emit (node:events:523:35)\n    at endReadableNT (node:internal/streams/readable:1367:12)\n    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)'}
2023-07-11 03:47:57,829 - 160986 - hummingbot.core.event.event_reporter - EVENT_LOG - {"timestamp": 1689047277.0, "order_id": "add-WETH-USDC.E-1689047271210465", "order_action": "LPType.ADD", "event_name": "RangePositionUpdateFailureEvent", "event_source": "uniswapLP_ethereum_arbitrum_one"}

The text was updated successfully, but these errors were encountered:

fengtality · 2023-07-11T22:55:46Z

This bug is because the UniswapLP connector currently uses the Uniswap Smart Order Router to fetch the price, but doesn't provide for the option to fetch the price from the pool that was added in #136.

See https://github.com/hummingbot/gateway/blob/main/src/connectors/uniswap/uniswap.lp.helper.ts for the code that utilizes the router.

Bounty

Description: Change the UniswapLP connector code so that when useRouter in uniswap.yml is false, it uses the direct pool method to fetch prices
Sponsor: Hummingbot Foundation
Bounty Rationale: Uniswap is the Gold DEX connector for Epoch 5
Bounty Amount: 50,000 HBOT (P2)
Developer Payment: 50,000 HBOT (100%)
Status: Open

fengtality · 2023-07-11T22:58:06Z

@VPashkov Are you interested in taking this bounty? It should be similar to the work you did in #136

VPashkov · 2023-07-13T02:21:44Z

@fengtality, unfortunately, I'm unavailable for two weeks.
@zedquach, you wanted to take #112. Maybe you can work on this one? If you have any questions, I will be happy to answer them.

fengtality · 2023-07-13T03:32:06Z

no prob. I think I understand the issue and can solve it

…

On Wed, Jul 12, 2023, 7:21 PM Vadim ***@***.***> wrote: @fengtality <https://github.com/fengtality>, unfortunately, I'm unavailable for two weeks. @zedquach <https://github.com/zedquach>, you wanted to take #112 <#112>. Maybe you can work on this one? If you have any questions, I will be happy to answer them. — Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANWHVV6PSEU7UUC5KTHQHDXP5LUHANCNFSM6AAAAAA2FMNUBQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

fengtality · 2023-07-13T22:53:55Z

@vic-en Can you take this bounty? I think this issue may be related to the chain configuration change, since the call to getTokenByAddress now returns undefined in https://github.com/hummingbot/gateway/blob/main/src/connectors/uniswap/uniswap.lp.ts#L74.

Arnique · 2023-07-16T14:52:02Z

Getting the same error. Any updates?

ZAABY · 2023-07-16T15:56:08Z

This bug is because the UniswapLP connector currently uses the Uniswap Smart Order Router to fetch the price, but doesn't provide for the option to fetch the price from the pool that was added in #136.

See https://github.com/hummingbot/gateway/blob/main/src/connectors/uniswap/uniswap.lp.helper.ts for the code that utilizes the router.

Bounty

Description: Change the UniswapLP connector code so that when useRouter in uniswap.yml is false, it uses the direct pool method to fetch prices

Sponsor: Hummingbot Foundation

Bounty Rationale: Uniswap is the Gold DEX connector for Epoch 5

Bounty Amount: 50,000 HBOT (P2)

Developer Payment: 50,000 HBOT (100%)

Status: Open

Bounty Acctepted!

fengtality · 2023-07-16T17:37:36Z

Bounty Acctepted!

FYI the adding liquidity issue is solved on development by this PR: #153

However, the bounty for #154 is still OPEN. Do you want to take that one?

ZAABY · 2023-07-19T20:59:36Z

Hello Everyone!
So I came to some solution but facing the attached error. Can any one help me what to do to get out of it?

nikspz added the bug Something isn't working label Jul 11, 2023

nikspz transferred this issue from hummingbot/hummingbot Jul 11, 2023

nikspz added the uniswap-lp label Jul 11, 2023

nikspz mentioned this issue Jul 11, 2023

feat/Interact directly with the pool in Uniswap connector #136

Merged

2 tasks

fengtality added this to Bounties Board Jul 11, 2023

fengtality moved this to Open in Bounties Board Jul 11, 2023

fengtality mentioned this issue Jul 11, 2023

fix/dont use router in uniswaplp #153

Merged

2 tasks

nikspz moved this from Open to Submitted in Bounties Board Jul 12, 2023

nikspz moved this from Submitted to Open in Bounties Board Jul 12, 2023

fengtality closed this as completed Jul 16, 2023

github-project-automation bot moved this from Open to Assigned in Bounties Board Jul 16, 2023

fengtality moved this from Assigned to Merged in Bounties Board Jul 16, 2023

nikspz moved this from Merged to Paid in Bounties Board Jul 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UniswapLP - Error adding liquidity #152

UniswapLP - Error adding liquidity #152

nikspz commented Jul 11, 2023 •

edited

Loading

fengtality commented Jul 11, 2023

fengtality commented Jul 11, 2023

VPashkov commented Jul 13, 2023

fengtality commented Jul 13, 2023 via email

fengtality commented Jul 13, 2023

Arnique commented Jul 16, 2023

ZAABY commented Jul 16, 2023

Bounty

Bounty

fengtality commented Jul 16, 2023

ZAABY commented Jul 19, 2023

UniswapLP - Error adding liquidity #152

UniswapLP - Error adding liquidity #152

Comments

nikspz commented Jul 11, 2023 • edited Loading

Describe the bug

Steps to reproduce

Release version

Type of installation

Attach required files

fengtality commented Jul 11, 2023

Bounty

fengtality commented Jul 11, 2023

VPashkov commented Jul 13, 2023

fengtality commented Jul 13, 2023 via email

fengtality commented Jul 13, 2023

Arnique commented Jul 16, 2023

ZAABY commented Jul 16, 2023

Bounty

Bounty

fengtality commented Jul 16, 2023

ZAABY commented Jul 19, 2023

nikspz commented Jul 11, 2023 •

edited

Loading