Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT][Exchange Oracle] Return correct url from get_reputation_oracle_url #2562

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

Bobronium
Copy link
Collaborator

Added in #2428, get_reputation_oracle_url was mistakenly returning url for recording oracle.

This PR fixes it and adds previously missing tests.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:49pm
human-dashboard-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:49pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:49pm
faucet-server ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 3:49pm

@Bobronium Bobronium changed the title [CVAT][Exchange Oracle] Use correct url for get_reputation_oracle_url [CVAT][Exchange Oracle] Return correct url from get_reputation_oracle_url Sep 26, 2024
@Bobronium Bobronium changed the base branch from main to develop September 26, 2024 15:40
Restarting the job doesn't help.
@Bobronium
Copy link
Collaborator Author

@Dzeranov, could you take a look?

@Bobronium Bobronium merged commit 2bb8111 into develop Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants