[Fortune Exchange Oracle] Change reward_amount to string (#2553)

* change reward amount to string * add url to log
humanprotocol · Sep 25, 2024 · 463f374 · 463f374
1 parent a2e28c9
commit 463f374
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/apps/fortune/exchange-oracle/server/src/modules/job/job.dto.ts b/packages/apps/fortune/exchange-oracle/server/src/modules/job/job.dto.ts
@@ -99,7 +99,7 @@ export class JobDto {
   jobDescription?: string;
 
   @ApiProperty({ name: 'reward_amount' })
-  rewardAmount?: number;
+  rewardAmount?: string;
 
   @ApiProperty({ name: 'reward_token' })
   rewardToken?: string;

diff --git a/packages/apps/fortune/exchange-oracle/server/src/modules/job/job.service.ts b/packages/apps/fortune/exchange-oracle/server/src/modules/job/job.service.ts
@@ -172,8 +172,9 @@ export class JobService {
             data.fields?.includes(JobFieldName.RewardAmount) ||
             data.sortField === JobSortField.REWARD_AMOUNT
           ) {
-            job.rewardAmount =
-              manifest.fundAmount / manifest.submissionsRequired;
+            job.rewardAmount = (
+              manifest.fundAmount / manifest.submissionsRequired
+            ).toString();
           }
           if (data.fields?.includes(JobFieldName.RewardToken)) {
             job.rewardToken = TOKEN;
@@ -189,8 +190,8 @@ export class JobService {
 
     if (data.sortField === JobSortField.REWARD_AMOUNT) {
       jobs.sort((a, b) => {
-        const rewardA = a.rewardAmount ?? 0;
-        const rewardB = b.rewardAmount ?? 0;
+        const rewardA = Number(a.rewardAmount ?? 0);
+        const rewardB = Number(b.rewardAmount ?? 0);
         if (data.sort === SortDirection.DESC) {
           return rewardB - rewardA;
         } else {

diff --git a/packages/apps/human-app/server/src/integrations/exchange-oracle/exchange-oracle.gateway.ts b/packages/apps/human-app/server/src/integrations/exchange-oracle/exchange-oracle.gateway.ts
@@ -55,7 +55,7 @@ export class ExchangeOracleGateway {
       return response.data as T;
     } catch (e) {
       console.error(
-        `Error, while executing exchange oracle API call, error details: ${e}`,
+        `Error, while executing exchange oracle API call to ${options.url}, error details: ${e}`,
       );
       throw e;
     }