Fix Travis Builds #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis builds are failing on 5.6 which begs the question, should we even be testing 5.6? with the migration to 7.4, we _should_ be testing that.
they're allowed to fail, but they need to be included
required for wp unit
will add this back, i just can't clear the cache with my permissions
|
Note: Travis builds are still failing due to an outdated version of PHPUnit (the tests themselves are running & passing). I've updated the composer.json but I don't have access to log into the Travis machine to do any troubleshooting there. |
roborourke
reviewed
Apr 27, 2021
|
@jazzsequence yeah you have to specifically request machine access for public repos as it can be abused or provide a way for people to get potentially private env variables etc. Looks like the |
|
There were quite a few updates required more generally, agree regarding PHP 5.x so I've removed those:
|
roborourke
changed the title
roborourke
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
travis builds are failing on 5.6 which begs the question, should we even be testing 5.6?
with the migration to 7.4, we should be testing that.
This also bumps PHPUnit which also causes a travis build failure (though the unit tests run fine).
example (failing) build: https://travis-ci.org/github/humanmade/wp-redis-predis-client/jobs/519335994