Disconnect the Redis socket on fatal shutdown #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fatal error during socket read/write (such as a memory exhausted error) can result in a corrupted persistent socket for future PHP requests. This change explicitly disconnects the Redis socket on shutdown that happened with a fatal error.
The problem can be reproduced by enabling persistent connections, writing a large value to Redis:
Then attempting to read that value with a low enough memory limit:
This should cause a memory exhausted fatal error in predis/src/Connection/StreamConnection.php exiting the script but leaving the persistent socket in a connected state, which in subsequent requests leads to poisoning/corruption.