Incorrect pre_get_ready_cron_jobs implementation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a fatal error when something requests wp-cron.php while Cavalcade is in use: ``` Uncaught Error: Cannot use object of type stdClass as array in /public_html/wp-cron.php:121 ``` https://core.trac.wordpress.org/browser/trunk/src/wp-cron.php?marks=121#L112
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
|
I think there were places in the cavalcade code that expected an object, iirc it was to do with converting it into a |
roborourke
approved these changes
Jul 22, 2020
|
Released in 2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a fatal error when something requests wp-cron.php while Cavalcade is in use:
It seems that Cavalcade returns an object here, where WordPress is expecting an array:
https://core.trac.wordpress.org/browser/trunk/src/wp-cron.php?marks=121#L112