Add test coverage for text mode error #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It seems you did add a test in #175 (tests/test_misc.py/test_incorrect_load). Should we add the error message assertion in that one instead? That test should also probably live in the test_error.py file, but since it deviates us from cpython/tomllib I'm not sure it's worth moving it. |
hauntsaninja
commented
Oct 4, 2024
There was a problem hiding this comment.
Ah, good point. Missed that because I was just looking at the diff in your PR #229 :-)
I added the message in the location of the existing test. If we want to move it that's fine too (I can make the corresponding change in CPython)
|
If you have the energy to move it in CPython, let's do it here too in this PR! If not then this LGTM. |
Error message was added in hukkin#175
|
I'll actually just merge this now. We can consider moving the test separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message was added in #175