fix(core): fix bug where int vars were encoded as uint

hujw77 · Nov 27, 2022 · ec87d11 · ec87d11
1 parent bfd93a3
commit ec87d11
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 3 deletions.
diff --git a/.changeset/lemon-parents-check.md b/.changeset/lemon-parents-check.md
@@ -0,0 +1,6 @@
+---
+'@chugsplash/core': patch
+'@chugsplash/plugins': patch
+---
+
+Fixes bug where signed integers were encoded as unsigned integers
diff --git a/packages/core/src/languages/solidity/storage.ts b/packages/core/src/languages/solidity/storage.ts
@@ -162,7 +162,6 @@ const encodeVariable = (
       ]
     } else if (
       variableType.label.startsWith('uint') ||
-      variableType.label.startsWith('int') ||
       variableType.label.startsWith('enum')
     ) {
       if (

diff --git a/packages/plugins/chugsplash/SimpleStorage.config.ts b/packages/plugins/chugsplash/SimpleStorage.config.ts
@@ -1,4 +1,5 @@
 import { ChugSplashConfig } from '@chugsplash/core'
+import { ethers } from 'ethers'
 
 const config: ChugSplashConfig = {
   // Configuration options for the project:
@@ -12,7 +13,7 @@ const config: ChugSplashConfig = {
     FirstSimpleStorage: {
       contract: 'SimpleStorage',
       variables: {
-        testInt: 1,
+        testInt: ethers.constants.MinInt256.toString(),
         number: 1,
         stored: true,
         storageName: 'First',

diff --git a/packages/plugins/contracts/SimpleStorage.sol b/packages/plugins/contracts/SimpleStorage.sol
@@ -25,6 +25,10 @@ contract SimpleStorage {
     mapping(string => mapping(string => string)) public nestedMappingTest;
     mapping(uint8 => mapping(string => mapping(address => uint))) public multiNestedMapping;
 
+    function getTestInt() external view returns (int) {
+        return testInt;
+    }
+
     function getNumber() external view returns (uint8) {
         return number;
     }

diff --git a/packages/plugins/test/SimpleStorage.spec.ts b/packages/plugins/test/SimpleStorage.spec.ts
@@ -1,5 +1,5 @@
 import { expect } from 'chai'
-import { BigNumber, Contract } from 'ethers'
+import { BigNumber, Contract, constants } from 'ethers'
 
 describe('SimpleStorage', () => {
   let FirstSimpleStorage: Contract
@@ -10,6 +10,12 @@ describe('SimpleStorage', () => {
     FirstSimpleStorage = await chugsplash.getContract('FirstSimpleStorage')
   })
 
+  it('does set int', async () => {
+    expect(await FirstSimpleStorage.getTestInt()).deep.equals(
+      constants.MinInt256
+    )
+  })
+
   it('does set struct', async () => {
     const struct = await FirstSimpleStorage.getStruct()
     expect(struct[0]).equals(1)