fix(ct): remove unnecessary receive and fallback functions in updater…

… contracts
hujw77 · Apr 9, 2023 · b41ec91 · b41ec91
1 parent 9e5ce00
commit b41ec91
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/.changeset/orange-kids-clean.md b/.changeset/orange-kids-clean.md
@@ -0,0 +1,5 @@
+---
+'@chugsplash/contracts': patch
+---
+
+Remove unnecessary receive and fallback functions in updater contracts
diff --git a/packages/contracts/contracts/interfaces/IProxyUpdater.sol b/packages/contracts/contracts/interfaces/IProxyUpdater.sol
@@ -15,8 +15,4 @@ interface IProxyUpdater {
      * @param _segment New value for the segment of the storage slot.
      */
     function setStorage(bytes32 _key, uint8 _offset, bytes memory _segment) external;
-
-    receive() external payable;
-
-    fallback() external payable;
 }
diff --git a/packages/contracts/contracts/updaters/DefaultUpdater.sol b/packages/contracts/contracts/updaters/DefaultUpdater.sol
@@ -48,12 +48,4 @@ contract DefaultUpdater is ProxyUpdater {
     function setStorage(bytes32 _key, uint8 _offset, bytes memory _segment) external ifAdmin {
         super.setStorageValue(_key, _offset, _segment);
     }
-
-    receive() external payable {
-        revert("DefaultUpdater: caller is not an admin");
-    }
-
-    fallback() external payable {
-        revert("DefaultUpdater: cannot call implementation functions while update is in progress");
-    }
 }
diff --git a/packages/contracts/contracts/updaters/OZUUPSUpdater.sol b/packages/contracts/contracts/updaters/OZUUPSUpdater.sol
@@ -121,12 +121,4 @@ contract OZUUPSUpdater is ProxyUpdater {
     ) external ifChugSplashAdmin {
         super.setStorageValue(_key, _offset, _segment);
     }
-
-    receive() external payable {
-        revert("OZUUPSUpdater: caller is not an admin");
-    }
-
-    fallback() external payable {
-        revert("OZUUPSUpdater: cannot call implementation functions while update is in progress");
-    }
 }