fix(core): fix a couple bugs when deploying no-proxy contracts

hujw77 · Apr 10, 2023 · 1dee798 · 1dee798
1 parent 94402bc
commit 1dee798
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/wet-lobsters-accept.md b/.changeset/wet-lobsters-accept.md
@@ -0,0 +1,5 @@
+---
+'@chugsplash/core': patch
+---
+
+Fixes a couple errors when deploying no-proxy contracts
diff --git a/packages/core/src/config/parse.ts b/packages/core/src/config/parse.ts
@@ -933,7 +933,10 @@ const parseContractVariables = (
   cre: ChugSplashRuntimeEnvironment
 ): ParsedConfigVariables => {
   const parsedConfigVariables: ParsedConfigVariables = {}
-  if (!contractConfig.variables) {
+  if (
+    !contractConfig.variables ||
+    Object.keys(contractConfig.variables).length === 0
+  ) {
     return {}
   }
 

diff --git a/packages/core/src/languages/solidity/storage.ts b/packages/core/src/languages/solidity/storage.ts
@@ -627,6 +627,10 @@ export const computeStorageSegments = (
   contractConfig: ParsedContractConfig,
   dereferencer: ASTDereferencer
 ): Array<StorageSlotSegment> => {
+  if (contractConfig.kind === 'no-proxy') {
+    return []
+  }
+
   let segments: StorageSlotSegment[] = []
   for (const storageObj of Object.values(extendedLayout.storage)) {
     const configVarValue = contractConfig.variables[storageObj.configVarName]