memory: Allow info proc mapping on older gdb #1073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works now that we assume rwx if the Perms column is missing
hugsy
requested changes
Mar 10, 2024
| @@ -10590,9 +10590,6 @@ def parse_procfs_maps(cls) -> Generator[Section, None, None]: | |||
| @classmethod | |||
| def parse_gdb_info_proc_maps(cls) -> Generator[Section, None, None]: | |||
| """Get the memory mapping from GDB's command `maintenance info sections` (limited info).""" | |||
| if GDB_VERSION < (11, 0): | |||
There was a problem hiding this comment.
I don't think that's what you meant to do: on older versions, Perms is not exposed at all by GDB even on live process, for which we can know the permissions from procfs
However, removing this - and because parse_gdb_info_proc_maps is the first to be invoked when parsing mem mapping - it'll end up giving rwx to everything, which the unittest failures show quickly.
The reason it was mocked for version higher than 11 was to restore support for coredumps where this info is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works now that we assume rwx if the Perms column is missing