Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore CI coverage #1050

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Restore CI coverage #1050

merged 2 commits into from
Jan 20, 2024

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jan 20, 2024

Description

Restore the coverage comment functionality for PRs to a workable state

The reason it's broken is because of different security permissions between actions triggered by pull_request and pull_request_target.

This will need to be improved carefully by testing non-project commitors successfully trigger the action.

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added this to the 2024.05 milestone Jan 20, 2024
@github-actions GitHub Actions
Copy link

🤖 Coverage update for 0c5c295 🟢

Old New
Commit d8b84e5 0c5c295
Score 71.6206% 71.7779% (0.1573)

@hugsy hugsy mentioned this pull request Jan 20, 2024
Merged
4 tasks
@hugsy hugsy merged commit 62fd178 into use_info_proc_mapping Jan 20, 2024
1 check passed
@hugsy hugsy deleted the restore_ci_coverage branch January 20, 2024 18:36
hugsy added a commit that referenced this pull request Jan 20, 2024
@hugsy
Use info proc mapping (#1046)
c9a8b18 
## Description

Use `info proc mapping` as a first memory layout enumeration technique.

Removed `maintenance info sections` which is not about memory layout

Restore CI coverage (#1050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather approved these changes

@therealdreg therealdreg Awaiting requested review from therealdreg

Assignees
No one assigned
Labels
automation/ci
Projects
None yet
Milestone
2024.06
Development

Successfully merging this pull request may close these issues.
2 participants
@hugsy @Grazfather