Fix many minor bugs in several scripts #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
approved these changes
Jan 28, 2024
| self.__original_disassembler = ctx.instruction_iterator | ||
| ctx.instruction_iterator = cs_disassemble | ||
| else: | ||
| # `use-capstone` set to False | ||
| if ctx.instruction_iterator == cs_disassemble and self.__original_disassembler: | ||
| if ( |
There was a problem hiding this comment.
Do you prefer this style (four lines) over either 1 line or 2 with parens or 2 with \?
There was a problem hiding this comment.
I almost forgot: I started using black for gef-extras (only for now), and those kind of output were the result. I'm not sure how I feel yet about it.
There was a problem hiding this comment.
Ah yeah, that may be why I didn't like black (remember I said it was too opinonated and I didn't like the opinion).
I am 100% for auto-formatting everything! That will be nice and easy to check. I don't love black but I could live with it.
Comment on lines
+192
to
+194
| for insn in cs_disassemble( | ||
| location, length, skip=length * self.repeat_count, **kwargs | ||
| ): |
There was a problem hiding this comment.
I don't think we need (nor do I like) the hanging parens. Wastes lines imo.
Suggested change
| for insn in cs_disassemble( | |
| location, length, skip=length * self.repeat_count, **kwargs | |
| ): | |
| for insn in cs_disassemble( | |
| location, length, skip=length * self.repeat_count, **kwargs): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Motivation/Screenshots
restored to a workable state - for 2024.01 :
remotewindbgassemblelibc_function_argsis completely brokenHow Has This Been Tested ?
"Tested" indicates that the PR works and the unit test (i.e.
make test) run passes without issue.Checklist
adequate tests have been added.
CONTRIBUTING document.