Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize xorb upload #98

Merged
merged 13 commits into from
Dec 12, 2024
Merged

Parallelize xorb upload #98

merged 13 commits into from
Dec 12, 2024

Conversation

seanses
Copy link
Collaborator

@seanses seanses commented Nov 27, 2024 •
edited
Loading

Parallelize xorb upload and registration. Calls to register xorbs return immediately after computing a xorb hash so callers can continue with other work (e.g. dedup), and xorb data is queued internally to be uploaded and registered.

Achieving up to 1.8 Gbps upload speed against the ephemeral CAS.

@seanses seanses force-pushed the di/parallelize-xorb-upload branch from d02c317 to 480a976 Compare December 5, 2024 20:35
@seanses seanses force-pushed the di/parallelize-xorb-upload branch from 480a976 to eb34cf9 Compare December 5, 2024 20:41
@seanses seanses marked this pull request as ready for review December 5, 2024 20:51
@seanses seanses requested review from hoytak and assafvayner December 5, 2024 20:53
@seanses seanses requested a review from assafvayner December 9, 2024 21:22
assafvayner
assafvayner approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@assafvayner assafvayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, maybe check in with Hoyt too, and check in on RA's comment as well

@seanses seanses requested a review from rajatarya December 11, 2024 19:22
hoytak
hoytak approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@hoytak hoytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some concerns as discussed, but for now lgtm!

assafvayner
assafvayner reviewed Dec 12, 2024
View reviewed changes
@seanses seanses merged commit 13cac2d into main Dec 12, 2024
2 checks passed
@seanses seanses deleted the di/parallelize-xorb-upload branch December 12, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assafvayner assafvayner assafvayner approved these changes

@hoytak hoytak hoytak approved these changes

@rajatarya rajatarya Awaiting requested review from rajatarya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanses @hoytak @rajatarya @assafvayner