Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of shard and cache directories by endpoint. #154

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

hoytak
Copy link
Collaborator

@hoytak hoytak commented Jan 27, 2025

This PR separates out the shard and cache directories by endpoint, ensuring that shards and chunks do not mix between endpoints (E.g. production and development, etc.).

@hoytak hoytak requested review from assafvayner and seanses January 27, 2025 22:16
Copy link
Contributor

@assafvayner assafvayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly worried about the chance we get different directories in the case of huggingface.co vs hf.co since both are valid, but we'll see if that causes an issue down the line.

@hoytak hoytak force-pushed the hoytak/250127-endpoint-separation branch from b8449df to a7646be Compare January 28, 2025 01:53
@hoytak
Copy link
Collaborator Author

hoytak commented Jan 28, 2025

I'm slightly worried about the chance we get different directories in the case of huggingface.co vs hf.co since both are valid, but we'll see if that causes an issue down the line.

True, though I think that could be handled by a mapping layer on the python side.

@hoytak hoytak merged commit 0bc4927 into main Jan 28, 2025
4 checks passed
@hoytak hoytak deleted the hoytak/250127-endpoint-separation branch January 28, 2025 02:37
@seanses
Copy link
Collaborator

seanses commented Jan 28, 2025

I'm slightly worried about the chance we get different directories in the case of huggingface.co vs hf.co since both are valid, but we'll see if that causes an issue down the line.

@assafvayner The endpoint here is actually CAS endpoint not the Hub endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants