Only load the shard chunk dedup tables for the upload path #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Generally LGTM, but I lack context, I would prefer to get @seanses to approve
seanses
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the shard chunk lookup tables are read and loaded on startup for both upload and download. However, they are only needed for upload. This PR disables this step for the download path, as the current setup will be either one or the other, not both.
(In the old xet-core, these tables were loaded in the background, so this was less of an issue but meant more async and locking annoyance and so was dropped during the keyed hash update).