docs: add initial version of docs for PPOTrainer
#665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lvwerra
reviewed
Sep 8, 2023
There was a problem hiding this comment.
Thanks a lot for the docs contribution! The preview is also working now :) The PR looks in pretty good shape to me! I added some small suggestions here and there. I'll also let @vwxyzjn and @younesbelkada have a look.
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
- specified reference to reward model - added batched generator - added line of saving model - remove reference model
|
@lvwerra I already processed your comments and suggestions. |
lvwerra
approved these changes
Sep 8, 2023
Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
younesbelkada
approved these changes
Sep 11, 2023
kushal-tri
pushed a commit
to kushalarora/trl
that referenced
this pull request
Sep 19, 2023
* docs: add initial version of docs for `PPOTrainer` * Apply suggestions from code review Leandro Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * updated docs based on feedback leandro - specified reference to reward model - added batched generator - added line of saving model - remove reference model * Apply suggestions from code review Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> --------- Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* docs: add initial version of docs for `PPOTrainer` * Apply suggestions from code review Leandro Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> * updated docs based on feedback leandro - specified reference to reward model - added batched generator - added line of saving model - remove reference model * Apply suggestions from code review Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> --------- Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #623, I am proposing more elaborate docs for the
PPOTrainer.Closes #623