Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix test-save-trainer #36191

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

As per title, fixes the test. The default directory is indeed called trainer_output, so the test is not correctly checking it

@zucchini-nlp zucchini-nlp requested a review from ydshieh February 14, 2025 09:00
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Indeed, we changed that recently.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"""Test that output_dir defaults to 'tmp_trainer' when not specified."""

this has to be adjusted too.

Thank you

@zucchini-nlp zucchini-nlp merged commit 3bf02cf into huggingface:main Feb 14, 2025
10 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants