Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mllama fsdp #36000

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Mllama fsdp #36000

merged 6 commits into from
Feb 13, 2025

Conversation

blbadger
Copy link
Contributor

@blbadger blbadger commented Feb 1, 2025

What does this PR do?

Fixes # 35880

During the forward pass pixel values are sent do the device and datatype assigned to the patch embedding's weight rather than the device and datatype of the model. This prevents misassignment issues when training via FSDP, as the patch embedding's weight parameters are dispatched to the proper device and datatype before reference.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@qubvel

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@blbadger
Copy link
Contributor Author

blbadger commented Feb 5, 2025

@qubvel my pleasure, thanks for the suggestion! I have committed it and updated the branch.

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@qubvel qubvel requested a review from ArthurZucker February 5, 2025 09:01
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurZucker ArthurZucker merged commit 1614d19 into huggingface:main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants