[Moshi] disable automatic compilation if the model can't compile #35992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
approved these changes
Jan 31, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@ydshieh I agree the name is misleading, and has been repurposed for compilation things. Happy to rename it to |
|
I would love it renamed, but since it's an (despite being private) attribute of the important/base class (and we can do it in a separate PR, so you can merge this one quickly if you wish) |
|
yes, let's do it in a separate PR :) |
yaswanth19
pushed a commit
to yaswanth19/transformers
that referenced
this pull request
Feb 5, 2025
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Feb 5, 2025
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't trigger automatic compilation if the model can't compile. #34544 enabled automatic compilation with any compilation-ready cache. However, some models default to compilation-ready caches AND don't support compilation, e.g. Moshi
Supercedes #35986; Carved from #35989 to reduce the size of that PR.
Fixes Moshi generation tests, e.g.
py.test tests/models/moshi -k test_greedy_generate -vv