-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qwen2VLImageProcessorFast
into Qwen2VLProcessor
#35987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yeliudev for noticing this! See my comment for a more appropriate fix in my opinion. I don't think my suggestion would break anything, but pinging @ArthurZucker to be sure and for a final review.
Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
@yonigozlan Thanks for the suggestion! Indeed this should be better. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be great :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Add `Qwen2VLImageProcessorFast` into `Qwen2VLProcessor` * Use `AutoImageProcessor` instead Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> --------- Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
…35987) * Add `Qwen2VLImageProcessorFast` into `Qwen2VLProcessor` * Use `AutoImageProcessor` instead Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> --------- Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
…35987) * Add `Qwen2VLImageProcessorFast` into `Qwen2VLProcessor` * Use `AutoImageProcessor` instead Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> --------- Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
What does this PR do?
Add
Qwen2VLImageProcessorFast
intoQwen2VLProcessor
so that users can setuse_fast
when initializing the processor.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.