Fix usage of unpad_input function #35925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Rocketknight1
approved these changes
Jan 28, 2025
See huggingface#35899 In the [commit](Dao-AILab/flash-attention@cdbbe84) return type of `unpad_input` was changed. Now the code support older and newer versions
pavelgein
force-pushed
the
fix_unpad_input
branch
from
023afeb to
5b3e53d
Compare
|
@ArthurZucker Hi, could please have a look? |
|
cc @Cyrilvallez for final review if Arthur is busy! |
ArthurZucker
approved these changes
Feb 6, 2025
MekkCyber
pushed a commit
that referenced
this pull request
Feb 7, 2025
Fix usage of unpad_function See #35899 In the [commit](Dao-AILab/flash-attention@cdbbe84) return type of `unpad_input` was changed. Now the code support older and newer versions Co-authored-by: Pavel Gein <pavel.gein@gmail.com>
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
Fix usage of unpad_function See huggingface#35899 In the [commit](Dao-AILab/flash-attention@cdbbe84) return type of `unpad_input` was changed. Now the code support older and newer versions Co-authored-by: Pavel Gein <pavel.gein@gmail.com>
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
Fix usage of unpad_function See huggingface#35899 In the [commit](Dao-AILab/flash-attention@cdbbe84) return type of `unpad_input` was changed. Now the code support older and newer versions Co-authored-by: Pavel Gein <pavel.gein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the commit return type of
unpad_inputwas changed. Now the code support older and newer versionsFixes #35899
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker