Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc re list of models supporting TP #35864

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Update doc re list of models supporting TP #35864

merged 1 commit into from
Feb 12, 2025

Conversation

kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Jan 23, 2025 •
edited
Loading

What does this PR do?

Updated the list of models that support TP.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

ArthurZucker
ArthurZucker approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗 #35870 will need. a rebase!

@ArthurZucker
Copy link
Collaborator

Can you run make style to pass the cis? 🤗

@kwen2501 kwen2501 changed the title Add Tensor Parallel support for Gemma Update doc re list of models supporting TP Jan 29, 2025
@kwen2501
Copy link
Contributor Author

kwen2501 commented Jan 29, 2025 •
edited
Loading

@ArthurZucker thanks for the pointer! Super excited to see #35870 adding more models.

Since Gemma support has been added there, I am shrinking my PR to just update the doc. Would appreciate your review.

ArthurZucker
ArthurZucker approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep no worries! thanks 🤗

@ArthurZucker
Copy link
Collaborator

Long term we want a bot that just imports models and checks that they support and writes this to the file instead of manually doing it ourselves!

@ArthurZucker ArthurZucker merged commit f869d48 into huggingface:main Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwen2501 @ArthurZucker