Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyav pin to allow python 3.11 to be used #35823

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

CalOmnie
Copy link
Contributor

@CalOmnie CalOmnie commented Jan 21, 2025

What does this PR do?

Remove the two year old pin on av==9.2.0, this pin was made due to issue with the audio stream in av==10.0.0, this seems to not be an issue anymore sinve av is not used to extract audio streams anywhere.

Fixes #35803

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@vanpelt

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this pin was put in place and then forgotten about, because the latest version of av is now very far past 10.0. Thank you for fixing it, which in turn should make it a lot easier to use those models with modern Python!

@Rocketknight1 Rocketknight1 merged commit f4f33a2 into huggingface:main Jan 21, 2025
25 checks passed
@Rocketknight1
Copy link
Member

(I think this should be fine, but I'll keep an eye on our nightly CI after this is merged, just in case we get any new issues as a result - cc @ydshieh)

bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
* Remove pyav pin to allow python 3.11 to be used

* Run make fixup

---------

Co-authored-by: Louis Groux <louis.cal.groux@gmail.com>
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
* Remove pyav pin to allow python 3.11 to be used

* Run make fixup

---------

Co-authored-by: Louis Groux <louis.cal.groux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle python 3.11 for huggingface["video"] and dependencies
2 participants