Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated get_cached_models #35809

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Remove deprecated get_cached_models #35809

merged 2 commits into from
Jan 21, 2025

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jan 21, 2025

According to deprecation warning, method should have been removed in v4.39.0. Since we are now at v4.48.1, it should be safe 😄

I've checked all the codebase and examples and haven't found any occurrences where get_cached_models is being used.

@Wauplin Wauplin requested a review from a team January 21, 2025 10:20
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM!

@Wauplin Wauplin merged commit 7051c5f into main Jan 21, 2025
26 checks passed
@Wauplin Wauplin deleted the removed-deprecated-method branch January 21, 2025 15:08
bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
* Remove deprecated get_cached_models

* imports
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
* Remove deprecated get_cached_models

* imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants