Fix multi gpu loss sync condition, add doc and test #35743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techkang
requested review from
muellerzr,
SunMarc,
Rocketknight1 and
ArthurZucker
as code owners
|
Also fixed: #35078 |
|
@ArthurZucker Can you take a look at this PR? I think it's ready for merge. |
sugendran
pushed a commit
to sugendran/transformers
that referenced
this pull request
Jan 25, 2025
|
@techkang @ArthurZucker Any news on this? |
SunMarc
approved these changes
Feb 10, 2025
Comment on lines
53
to
54
| relative_broken = abs(sum_broken - sum_broken) / max(sum_base, sum_broken) | ||
|
|
There was a problem hiding this comment.
This is always 0, need a small fix here
There was a problem hiding this comment.
Thanks, I fixed it.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@SunMarc Tests are all green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Multi-gpu loss sync is controlled by the
average_tokens_across_devicesargument. However, it has a tiny bug (it doesn't work when the model uses a user-defined loss function) and lacks unit tests.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@muellerzr @ArthurZucker @SunMarc