-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniformize OwlViT and Owlv2 processors #35700
Uniformize OwlViT and Owlv2 processors #35700
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's super nice in terms of standardization!
@yonigozlan I found this one is required for my PR for zero-short |
@ArthurZucker This is ready for your review :) |
Also, it should be possible not to run slow tests with "run-slow: owlvit, owlv2" comment if you merge the latest main |
It triggers with the GitHub comment "run-slow: owlvit, owlv2" P.S. job name to check tests running "pytest/custom-tests" |
run-slow: owlvit, owlv2 |
This comment contains run-slow, running the specified jobs: ['models/owlv2', 'models/owlvit'] ... |
Oh cool thanks, so run-slow doesn't work anymore with a commit message? |
AFAIK not anymore, it was disabled |
if len(t) != max_num_queries: | ||
t = t + [" "] * (max_num_queries - len(t)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor nit (and bumping PR up in the meantime, cc @ArthurZucker ) but here would be nice to remove single-letter variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤗
What does this PR do?
Adds uniformized processors following #31911 for OwlViT and Owlv2.
Split from this PR #32841
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.