Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize OwlViT and Owlv2 processors #35700

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

yonigozlan
Copy link
Member

What does this PR do?

Adds uniformized processors following #31911 for OwlViT and Owlv2.
Split from this PR #32841

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yonigozlan yonigozlan mentioned this pull request Jan 14, 2025
40 tasks
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's super nice in terms of standardization!

@qubvel
Copy link
Member

qubvel commented Jan 21, 2025

@yonigozlan I found this one is required for my PR for zero-short pipeline to work as well 😄 so, it's perfect timing

@yonigozlan
Copy link
Member Author

@ArthurZucker This is ready for your review :)

@qubvel
Copy link
Member

qubvel commented Jan 22, 2025

Also, it should be possible not to run slow tests with "run-slow: owlvit, owlv2" comment if you merge the latest main

@qubvel
Copy link
Member

qubvel commented Jan 24, 2025

It triggers with the GitHub comment "run-slow: owlvit, owlv2"

P.S. job name to check tests running "pytest/custom-tests"

@qubvel
Copy link
Member

qubvel commented Jan 24, 2025

run-slow: owlvit, owlv2

Copy link

This comment contains run-slow, running the specified jobs: ['models/owlv2', 'models/owlvit'] ...

@yonigozlan
Copy link
Member Author

It triggers with the GitHub comment "run-slow: owlvit, owlv2"

Oh cool thanks, so run-slow doesn't work anymore with a commit message?

@qubvel
Copy link
Member

qubvel commented Jan 26, 2025

AFAIK not anymore, it was disabled

Comment on lines 174 to 175
if len(t) != max_num_queries:
t = t + [" "] * (max_num_queries - len(t))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nit (and bumping PR up in the meantime, cc @ArthurZucker ) but here would be nice to remove single-letter variables

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

@yonigozlan yonigozlan merged commit 336dc69 into huggingface:main Feb 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants