Add proper jinja2 error #35533
Merged
Add proper jinja2 error #35533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
failing test is unrelated, pinging @ArthurZucker for core maintainer review! |
Rocketknight1
force-pushed
the
cleanup_jinja_imports
branch
from
cc70a02 to
fc6aba8
Compare
gante
approved these changes
Jan 16, 2025
|
It's a dependency of |
4 tasks
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Jan 31, 2025
* Cleanup jinja2 imports * Raise a proper error if Jinja is missing * make fixup
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
* Cleanup jinja2 imports * Raise a proper error if Jinja is missing * make fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several users reported confusion in #34397 when
jinja2is not installed, because the code imports some submodules ofjinja2, and the error message when these submodules is undefined doesn't referencejinja2at all.This PR adds a proper error so people know what's going on!