add RAdamScheduleFree optimizer #35313
Merged
+67
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
reviewed
Dec 24, 2024
There was a problem hiding this comment.
Thanks for this contribution @nhamanasu ! Left a few comments
|
Thank you for the valuable feedback! |
|
Hi guys, is anyone working on this? |
|
I think I did everything I could do for merging this PR, and just waiting for the approval from @ArthurZucker (sorry for mentioning...) |
|
Could you just fix the conflits ? I will merge this right after ! |
|
Thanks for the fix, merging as the failing test is unrelated! |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Feb 12, 2025
* add RAdamScheduleFree optimizer * revert schedulefree version to the minimum requirement * refine is_schedulefree_available so that it can take min_version * refine documents --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
* add RAdamScheduleFree optimizer * revert schedulefree version to the minimum requirement * refine is_schedulefree_available so that it can take min_version * refine documents --------- Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
|
Sorry for the delayed follow-up, and thank you for taking care of the final fix to get this PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Integrates the new RAdamScheduleFree optimizer in meta's schedule_free.
This PR has greatly followed the previous PR to introduce schedule_free #30079
More details
test_trainer.py& confirmed the test passesBackgrounds
I recently made the RAdamScheduleFree optimizer, and it's been merged in schedule_free library since version 1.4.
RAdamScheduleFree eliminates:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @ydshieh @muellerzr