protect tensor parallel usage #34800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
loadams
reviewed
Nov 19, 2024
| @@ -5005,6 +5006,8 @@ def tensor_parallel(self, device_mesh): | |||
| device_mesh (`torch.distributed.DeviceMesh`): | |||
| The device mesh to use for tensor parallelism. | |||
| """ | |||
| if not is_torch_greater_or_equal_than_2_4: | |||
There was a problem hiding this comment.
Hi @ArthurZucker - this mismatch between the torch 2.4 check and 2.5 requirement means that torch 2.4 still hits this issue (where torch 2.3 is now working properly)
This was referenced Nov 19, 2024
kwen2501
reviewed
Nov 19, 2024
Comment on lines
+42
to
+47
| if is_torch_greater_or_equal_than_2_4: | ||
| from torch.distributed.tensor import Replicate | ||
| from torch.distributed.tensor.parallel import ( | ||
| ColwiseParallel, | ||
| RowwiseParallel, | ||
| ) |
There was a problem hiding this comment.
Actually, Replicate is in torch.distributed.tensor >= torch 2.5.
Between 2.0-2.4 (included), it is in torch.distributed._tensor.
Thus it seems there are two options:
Option 1:
try:
from torch.distributed.tensor import Replicate
except ImportError:
from torch.distributed._tensor import Replicate
Option 2:
bump the requirement to 2.5.
ColwiseParallel and RowwiseParallel well exists since 2.0.
loadams
added a commit
to microsoft/DeepSpeed
that referenced
this pull request
Nov 22, 2024
Reverts #6759 Requires from transformers: huggingface/transformers#34816 huggingface/transformers#34800 Todo: - [x] Need to merge first PR to get support for torch 2.4
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #34795