PEFT fix: T5 prefix-tuning with new cache format #34312
Open
+126
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes prefix tuning for T5 models which started breaking after the recent compile-compatibility PR. However, note this will not enable correct prefix tuning unless huggingface/peft#2096 (review) is merged
The main issue was that in new cache format we don't concatenate new key/values with cached key/values if
past_key_values.is_updated
. That issue is fixed on PEFT side by init a cache object and settingis_updated=False
.Another issue is the mask shape mismatch since we have to extend
cross_attention_mask
to account for new virtual tokens. Current PR adds enables it but I am also thinking if it will be possible to do in PEFT and pass already extended attention masks?Tested with the below code for T5:
cc @BenjaminBossan wdyt?