Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for issue #34294 #34295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug Fix for issue #34294 #34295

wants to merge 1 commit into from

Conversation

fpgaminer
Copy link
Contributor

Update SiglipVisionEmbeddings.forward to cast input to correct dtype before embedding it.

Fixes # 34294

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts @qubvel

Update SiglipVisionEmbeddings.forward to cast input to correct dtype before embedding it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant