Sync token-classification pipeline with Hub spec #34064
Open
+39
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rocketknight1
force-pushed
the
sync_token_classification_and_zero_shot
branch
from
e911c78
to
73e256c
Compare
|
@Rocketknight1 these specs comes from https://github.com/huggingface/huggingface.js/blob/main/packages/tasks/src/tasks/zero-shot-classification/spec/output.json (PR huggingface/huggingface.js#449). When we wrote them we tried to be as consistent as possible with the existing but if there are some discrepancies, we can also update the specs correctly. Some tasks are more popular and have been reviewed/reworked several times but the zero-shot classification is not one of them 😕 |
Rocketknight1
force-pushed
the
sync_token_classification_and_zero_shot
branch
from
ba1f33b
to
f8fa11e
Compare
Rocketknight1
changed the title
|
(This PR is ready, just on hold until the next release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One unusual change this time: The TokenClassificationPipeline put the docstrings in an odd place, with a decorator. As far as I can tell, this isn't necessary at all - I just put them in the normal place (which also un-breaks my compatibility checker).
cc @Wauplin - there's an output discrepancy for the
zero-shotpipeline, but I can't figure out what output format the Hub spec actually wants whenmulti-labelisTrue. Where did that Hub spec come from?