Fixed docstring for cohere model regarding unavailability of prune_he… #33253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad() methods The docstring mentions that cohere model supports prune_heads() methods. I have fixed the docstring by explicitly mentioning that it doesn't support that functionality.
LysandreJik
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks for your PR @mnauf!
As this isn't a functionality that's commonly supported anymore, I'd just remove the mention of pruned heads altogether
Comment on lines
+639
to
+640
| library implements for all its model (such as downloading or saving, resizing the input embeddings etc.). This model | ||
| doesn't support pruning heads method. |
There was a problem hiding this comment.
Suggested change
| library implements for all its model (such as downloading or saving, resizing the input embeddings etc.). This model | |
| doesn't support pruning heads method. | |
| library implements for all its model (such as downloading or saving, resizing the input embeddings etc.). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring mentions that cohere model supports prune_heads() methods. I have fixed the docstring by explicitly mentioning that it doesn't support that functionality.
What does this PR do?
Fixes #33249
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.