Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dynamic resolution for vivit #30630

Merged
merged 19 commits into from
May 9, 2024
Merged

Enable dynamic resolution for vivit #30630

merged 19 commits into from
May 9, 2024

Conversation

jla524
Copy link
Contributor

@jla524 jla524 commented May 3, 2024 •
edited by amyeroberts
Loading

What does this PR do?

Addresses #30579 (issue)

Who can review?

@amyeroberts

amyeroberts
amyeroberts reviewed May 7, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Just a few nit comments

src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
tests/models/vivit/test_modeling_vivit.py Outdated Show resolved Hide resolved
tests/models/vivit/test_modeling_vivit.py Outdated Show resolved Hide resolved
jla524 and others added 7 commits May 7, 2024 17:20
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
3022649 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
d46b1a4 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
8299ae9 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update tests/models/vivit/test_modeling_vivit.py
47b6e9c 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524
Merge branch 'vivit_dynamic_resolution' of github.com:jla524/transfor…
976664d 
…mers into vivit_dynamic_resolution
@jla524 @amyeroberts
Update tests/models/vivit/test_modeling_vivit.py
eec7f61 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524
Merge branch 'vivit_dynamic_resolution' of github.com:jla524/transfor…
d9a0626 
…mers into vivit_dynamic_resolution
@amyeroberts amyeroberts mentioned this pull request May 8, 2024
Open
11 tasks
amyeroberts
amyeroberts reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the models and iterating on this!

Just a few small nits. For the quality checks, running make fixup and pushing the changes should resolve them

tests/models/vivit/test_modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
src/transformers/models/vivit/modeling_vivit.py Outdated Show resolved Hide resolved
jla524 and others added 8 commits May 8, 2024 09:51
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
b342bab 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update tests/models/vivit/test_modeling_vivit.py
eed482a 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
12e8aa1 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
c5df2fb 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
da54336 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524 @amyeroberts
Update src/transformers/models/vivit/modeling_vivit.py
23d2812 
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@jla524
fix: style check
851ff5b
@jla524
Merge branch 'vivit_dynamic_resolution' of github.com:jla524/transfor…
810eba9 
…mers into vivit_dynamic_resolution
amyeroberts
amyeroberts approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and improving the library's models!

@amyeroberts amyeroberts merged commit 8c5b3c1 into huggingface:main May 9, 2024
17 checks passed
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request May 10, 2024
@jla524 @amyeroberts @zucchini-nlp
Enable dynamic resolution for vivit (huggingface#30630)
b78f496 
* feat: enable dynamic resolution for vivit

* fix: formatting

* remove: print statement for testing

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update tests/models/vivit/test_modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update tests/models/vivit/test_modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update tests/models/vivit/test_modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* fix: style check

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
itazap pushed a commit that referenced this pull request May 14, 2024
@jla524 @amyeroberts
Enable dynamic resolution for vivit (#30630)
3559825 
* feat: enable dynamic resolution for vivit

* fix: formatting

* remove: print statement for testing

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update tests/models/vivit/test_modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update tests/models/vivit/test_modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update tests/models/vivit/test_modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update src/transformers/models/vivit/modeling_vivit.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* fix: style check

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nileshkokane01 nileshkokane01 nileshkokane01 left review comments

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jla524 @nileshkokane01 @amyeroberts