Update config class check in auto factory #29854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code for custom classes checks that
model_class.config_class
matchesconfig_class
, but this test is behaving oddly - it's returning a failure even though the two classes look identical to me. I changed the test to a string comparison test instead - it's possible that we're just initializing the two classes in slightly different ways, and that's creating two different objects that still represent the same class.Update: The underlying cause is not my original PR, but PR #29262. The check is failing because we now use
importlib.machinery.SourceFileLoader()
rather thanimportlib.import_module
, and this causes the two classes to not be equal (even though all their attributes are the same). I think the string comparison test should work fine as a solution for now!Fixes #29828
(Probably) fixes #30149