Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chat template warnings/guides #27634

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

Rocketknight1
Copy link
Member

The default ChatML template doesn't add a BOS token, but some models expect it. This PR makes a small update to the docs and warning messages to make users more aware of the potential issue here.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 21, 2023

The documentation is not available anymore as the PR was closed or merged.

docs/source/en/chat_templating.md Outdated Show resolved Hide resolved
Rocketknight1 and others added 2 commits November 27, 2023 16:49
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
@Rocketknight1 Rocketknight1 merged commit 74a3ceb into main Nov 27, 2023
3 checks passed
@Rocketknight1 Rocketknight1 deleted the chatml_template_update branch November 27, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants