Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate TransfoXL #27607

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Deprecate TransfoXL #27607

merged 7 commits into from
Nov 24, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Nov 20, 2023 •
edited
Loading

What does this PR do?

Deprecate TransfoXL as discussed.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 20, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh force-pushed the deprecated_2_modesl branch from 617b265 to 67ab444 Compare November 21, 2023 08:19
ydshieh
ydshieh commented Nov 21, 2023
View reviewed changes
Copy link
Collaborator Author

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to ease the review

docs/source/es/converting_tensorflow_models.md Show resolved Hide resolved
docs/source/it/converting_tensorflow_models.md Show resolved Hide resolved
docs/source/pt/converting_tensorflow_models.md Show resolved Hide resolved
src/transformers/commands/convert.py Show resolved Hide resolved
src/transformers/pipelines/text_generation.py Outdated Show resolved Hide resolved
src/transformers/pipelines/text_generation.py Outdated Show resolved Hide resolved
tests/generation/test_utils.py Show resolved Hide resolved
utils/check_repo.py Show resolved Hide resolved
@ydshieh ydshieh requested a review from LysandreJik November 21, 2023 10:18
@LysandreJik LysandreJik self-assigned this Nov 23, 2023
LysandreJik
LysandreJik approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yih-Dar!

Additionnally I'd log a warning on load of this model that it was deprecated due to security issues, urging users to read this document (and linking to it).

I'd log it as logger.error in the tokenizer's __init__.

docs/source/en/model_doc/transfo-xl.md Outdated Show resolved Hide resolved
src/transformers/models/auto/configuration_auto.py Outdated Show resolved Hide resolved
src/transformers/pipelines/text_generation.py Outdated Show resolved Hide resolved
docs/source/en/model_doc/transfo-xl.md Outdated Show resolved Hide resolved
ydshieh and others added 4 commits November 24, 2023 10:09
@ydshieh ydshieh merged commit 7293fdc into main Nov 24, 2023
3 checks passed
@ydshieh ydshieh deleted the deprecated_2_modesl branch November 24, 2023 10:48
@ydshieh ydshieh mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees

@LysandreJik LysandreJik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydshieh @HuggingFaceDocBuilderDev @LysandreJik