Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-test_torch] skip test_tf_from_pt_safetensors for 4 models #27481

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Skip test_tf_from_pt_safetensors tests for MobileBert, TransfoXL, SPeech2text and XGLM

@ArthurZucker ArthurZucker changed the title skip 4 tests [CI-test_torch] skip 4 tests test_tf_from_pt_safetensors Nov 14, 2023
@ArthurZucker ArthurZucker changed the title [CI-test_torch] skip 4 tests test_tf_from_pt_safetensors [CI-test_torch] skip test_tf_from_pt_safetensors for 4 models Nov 14, 2023
@ArthurZucker ArthurZucker merged commit e107ae3 into main Nov 14, 2023
3 checks passed
@ArthurZucker ArthurZucker deleted the skip-ci branch November 14, 2023 09:34
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@Saibo-creator
Copy link
Contributor

Hello, @ArthurZucker
Thanks for fixing the broken tests. I have made a PR and the tests failed because of the broken tests, how could I rerun the tests ?

#26304

@ArthurZucker
Copy link
Collaborator Author

I'll re-run them for you!

@VsonicV
Copy link
Contributor

VsonicV commented Nov 14, 2023

@ArthurZucker Hi, I have rebased my PR #27351 with your latest commits, but the same CI failure still persists with speech_to_text (only speech_to_text_2 is skipped in the current PR). We need to skip test_tf_from_pt_safetensors tests for speech_to_text as well. Thanks!

@ArthurZucker
Copy link
Collaborator Author

Thanks! @Rocketknight1 is working on a broader fix, I don't really mind skipping this test for all the other failing PRs

@Rocketknight1
Copy link
Member

The proper fix is here #27490

Saibo-creator pushed a commit to epfl-dlab/transformers-GCD-PR that referenced this pull request Nov 15, 2023
…ggingface#27481)

* skip 4 tests

* nits

* style

* wow it's not my day
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants