Backward compatibility fix for the Conversation class #27176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
reviewed
Oct 31, 2023
Comment on lines
+172
to
175
| if self.messages[-1]["role"] != "user" or self._num_processed_user_inputs == len(self._user_messages): | ||
| return self._user_messages | ||
|
|
||
| return self._user_messages[:-1] |
There was a problem hiding this comment.
Could we have a bit of comments about why this conditions and their output values?
There was a problem hiding this comment.
I mean hard to understand why self._user_messages when self.messages[-1]["role"] != "user"
ydshieh
approved these changes
Oct 31, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve our handling of the old
past_user_inputsproperty a bit, and revert a hack in the tests because it now works properly. Should fix all the tests that were red!cc @ydshieh