device agnostic models testing #27146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ji-huazhong
changed the title
|
Thanks for opening this PR @statelesshz ! Let us know when you'd like a review |
ji-huazhong
force-pushed
the
device-agnostic-models-testing
branch
from
fa43b77 to
28aef47
Compare
ji-huazhong
force-pushed
the
device-agnostic-models-testing
branch
from
28aef47 to
9d37036
Compare
ji-huazhong
force-pushed
the
device-agnostic-models-testing
branch
from
9d37036 to
e94cc76
Compare
ji-huazhong
changed the title
|
Due to network issue， it's not easy to download the model weights on huggingface hub from my area, so I take |
|
Marking this ready for review :-) @ydshieh and @amyeroberts |
amyeroberts
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Another great PR - thank you!
Happy to merge once @ydshieh gives his 👍
| def test_generate_fp16(self): | ||
| config, input_dict = self.model_tester.prepare_config_and_inputs() | ||
| input_ids = input_dict["input_ids"] | ||
| attention_mask = input_ids.ne(1).to(torch_device) | ||
| model = self.all_generative_model_classes[0](config).eval().to(torch_device) | ||
| if torch_device == "cuda": | ||
| model.half() | ||
| model.half() |
ydshieh
approved these changes
Oct 31, 2023
| @@ -363,7 +369,8 @@ def test_sampling(self): | |||
| self.assertIn(zs[2][0].detach().cpu().tolist(), [self.EXPECTED_OUTPUT_0, self.EXPECTED_OUTPUT_0_PT_2]) | |||
|
|
|||
| @slow | |||
| @require_torch_gpu | |||
| @require_torch_accelerator | |||
| @require_torch_fp16 | |||
There was a problem hiding this comment.
Oops, the fp16 decorator was misused here. Thanks for pointing it out
|
Nice to know bert works well on NPU! |
|
Thank you @statelesshz the king of NPU! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* device agnostic models testing * add decorator `require_torch_fp16` * make style * apply review suggestion * Oops, the fp16 decorator was misused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #25654 (comment)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.