Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in warning message #27055

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Conversation

liuxueyang
Copy link
Contributor

@liuxueyang liuxueyang commented Oct 25, 2023

Fix a typo in the warning message. The value of default_cache_path is ~/.cache/huggingface/hub not ~/.cache/huggingface/transformers.

v4.22.0 is the earlist version that contains those changes in PR #18492

@liuxueyang
Copy link
Contributor Author

It's not a typo. I guess this is a missing change in the PR #18492

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these!
Rebasing should fix the ci 😉

The path of `default_cache_path` is hf_cache_home/hub. There is no
directory named transformers under hf_cache_home
v4.22.0 is the earlist version that contains those changes in PR huggingface#18492
@liuxueyang
Copy link
Contributor Author

Already rebased and CI passed.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@ArthurZucker
Copy link
Collaborator

Sorry for the delay I'll merge 😉

@ArthurZucker ArthurZucker merged commit 80e9f76 into huggingface:main Nov 24, 2023
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants