Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoBackbone] Add test #26094

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

This PR adds a test which verifies that out_indices and out_features get saved properly.

The test fails if a Backbone class first inherits from PretrainedConfig, then from BackboneConfigMixin.

@NielsRogge NielsRogge mentioned this pull request Sep 11, 2023
4 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 11, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! ❤️

@NielsRogge
Copy link
Contributor Author

@amyeroberts feel free to take over, I see there's an issue regarding TimmBackboneTester

@ArthurZucker
Copy link
Collaborator

(She will be of for a while now, do you need this to be taken over?)

@NielsRogge
Copy link
Contributor Author

NielsRogge commented Sep 16, 2023

I've fixed it, feel free to merge

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test

@ArthurZucker ArthurZucker merged commit de8bec6 into huggingface:main Sep 18, 2023
MKhalusova pushed a commit to MKhalusova/transformers that referenced this pull request Sep 19, 2023
* Add test

* Add config_class
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* Add test

* Add config_class
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* Add test

* Add config_class
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* Add test

* Add config_class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants