Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart check #25955

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Fix smart check #25955

merged 3 commits into from
Sep 4, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 4, 2023

What does this PR do?

Fix #25944

Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ydshieh 🙂

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 4, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Sep 4, 2023

Going to merge as not to block the release.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Sep 4, 2023

(once #25963 is merged)

@ydshieh ydshieh merged commit 44d2c19 into main Sep 4, 2023
19 of 21 checks passed
@ydshieh ydshieh deleted the fix_smart_check branch September 4, 2023 16:54
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As long as the performances are following 😉

parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#25871 slows down non-CPU runs
5 participants