Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #25893

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Update setup.py #25893

merged 1 commit into from
Aug 31, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Aug 31, 2023

What does this PR do?

The breakup in #24080 wasn't completely successfully 😭

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 31, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator Author

ydshieh commented Aug 31, 2023

I think the failing tests are fixed on main right?

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

Yep - failing tests were on main. @ArthurZucker fixed in #25890

@ydshieh ydshieh merged commit 3fb1535 into main Aug 31, 2023
18 of 22 checks passed
@ydshieh ydshieh deleted the update_setup branch August 31, 2023 16:54
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
update

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
update

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
update

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants