Update-llama-code #25826
Merged
Update-llama-code #25826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com>
Co-authored-by: pcuenca <pedro@latenitesoft.com>
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
commented
Aug 30, 2023
| @@ -316,36 +322,8 @@ def save_vocabulary(self, save_directory: str, filename_prefix: Optional[str] = | |||
|
|
|||
| return (out_vocab_file,) | |||
|
|
|||
| def build_inputs_with_special_tokens( | |||
There was a problem hiding this comment.
~removed as it is not used ~ is rarely used, nut still let's keep it.
| @@ -587,8 +592,8 @@ def main(): | |||
| end | |||
| """, | |||
| ] | |||
| tokenizer = CodeLlamaTokenizer.from_pretrained("codellama/CodeLlama-7b-hf") | |||
| tokenizer_fast = CodeLlamaTokenizerFast.from_pretrained("codellama/CodeLlama-7b-hf") | |||
| tokenizer = CodeLlamaTokenizer.from_pretrained("codellama/CodeLlama-7b-Instruct-hf") | |||
There was a problem hiding this comment.
the other model does not support infiling
osanseviero
reviewed
Aug 31, 2023
amyeroberts
reviewed
Aug 31, 2023
| if not conversation.new_user_input.startswith(B_SYS) or E_SYS not in conversation.new_user_input: | ||
| conversation.new_user_input = B_SYS + DEFAULT_SYSTEM_PROMPT + E_SYS + conversation.new_user_input | ||
| else: | ||
| raise ValueError("Last message must be from user") |
There was a problem hiding this comment.
Do we not want to check that the conversation ids start with B_SYS and contain E_SYS even if we're not using the default prompt?
There was a problem hiding this comment.
No this was just to add the system prompt if there are no system prompt. Now we just let the user define the system prompt!
| add_bos_token=True, | ||
| add_eos_token=False, | ||
| use_default_system_prompt=False, |
There was a problem hiding this comment.
The additional args should be documented in the doc string
There was a problem hiding this comment.
Indeed thanks
There was a problem hiding this comment.
(not for this PR) The add_bos_token and add_eos_token are not documented, and the args are in a very different order than the docstring
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
…ransformers into update-llama-code
LysandreJik
approved these changes
Sep 1, 2023
| add_bos_token=True, | ||
| add_eos_token=False, | ||
| use_default_system_prompt=False, |
There was a problem hiding this comment.
(not for this PR) The add_bos_token and add_eos_token are not documented, and the args are in a very different order than the docstring
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* some bug fixes * updates * Update code_llama.md Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com> * Add co author Co-authored-by: pcuenca <pedro@latenitesoft.com> * add a test * fixup * nits * some updates * fix-coies * adress comments * nits * nits * fix docsting * Apply suggestions from code review Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * update * add int for https://huggingface.co/spaces/hf-accelerate/model-memory-usage --------- Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com> Co-authored-by: pcuenca <pedro@latenitesoft.com> Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* some bug fixes * updates * Update code_llama.md Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com> * Add co author Co-authored-by: pcuenca <pedro@latenitesoft.com> * add a test * fixup * nits * some updates * fix-coies * adress comments * nits * nits * fix docsting * Apply suggestions from code review Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * update * add int for https://huggingface.co/spaces/hf-accelerate/model-memory-usage --------- Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com> Co-authored-by: pcuenca <pedro@latenitesoft.com> Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* some bug fixes * updates * Update code_llama.md Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com> * Add co author Co-authored-by: pcuenca <pedro@latenitesoft.com> * add a test * fixup * nits * some updates * fix-coies * adress comments * nits * nits * fix docsting * Apply suggestions from code review Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * update * add int for https://huggingface.co/spaces/hf-accelerate/model-memory-usage --------- Co-authored-by: Omar Sanseviero <osanseviero@users.noreply.github.com> Co-authored-by: pcuenca <pedro@latenitesoft.com> Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update based on reviews from Llama team and nits here and there!