Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated visual_question_answering.md to Korean #25679

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

wonhyeongseo
Copy link
Contributor

@wonhyeongseo wonhyeongseo commented Aug 23, 2023

What does this PR do?

Translated the visual_question_answering.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team OSSCA, may you please review this PR? @bolizabeth, @nuatmochoi, @heuristicwave, @mjk0618, @keonju2, @harheem, @HongB1, @junejae, @54data, @Sunmin0520, @seank021, @augustinLib, @sronger, @TaeYupNoh, @kj021, @eenzeenee

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR? @sgugger, @ArthurZucker, @stevhliu

tosquash: add code blocks
~L34 14:25
~L126 16:52
~L224 17:00
~L335 17:11
~EOF 17:18
Copy link
Contributor Author

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self correction with grammar checking.

docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
@wonhyeongseo
Copy link
Contributor Author

안녕하세요!

🔥 번역에 참여해주신 모든 분들께 정말 감사드립니다. 이번 번역에서는 특정 이미지에 대해서 설명이 나와 보면서 번역이 알맞는지 확인해야했습니다. 오랜만에 번역하는 것이다보니 오류가 많을 것으로 예상되는데요. 어떤 부분이든 모두 주저없이 말씀해주세요 :)

리뷰는 일방적인 수용이 아닌 서로간의 대화를 전제로 이루어집니다. 때문에 "어라, 이건 내가 맞아!"라고 주장해주시면 오히려 더 재밌는 리뷰 시간이 될 것입니다. 지금까지 최고의 리뷰를 꾸준히 올려주시는 @nuatmochoi 님 🥇 , @heuristicwave 님 🥈 , @sim-so 님 🥉 도 모두 리뷰 자유롭게 올려주세요. 감사합니다. 💯 😆

docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
docs/source/ko/tasks/visual_question_answering.md Outdated Show resolved Hide resolved
Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
@wonhyeongseo wonhyeongseo marked this pull request as ready for review August 24, 2023 15:16
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks so much for your translation 🤗

@stevhliu stevhliu merged commit f26099e into huggingface:main Aug 24, 2023
8 checks passed
@wonhyeongseo wonhyeongseo deleted the ko_vqa branch August 24, 2023 21:01
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
…ingface#25679)

* docs: ko: visual_question_answering.md

* feat: chatgpt draft

tosquash: add code blocks

* fix: manual edits

~L34 14:25
~L126 16:52
~L224 17:00
~L335 17:11
~EOF 17:18

* fix: self-correction

* amend grammar, phrasing

* docs: add new entry to _toctree.yml

* fix: use terms from glossary

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

---------

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
…ingface#25679)

* docs: ko: visual_question_answering.md

* feat: chatgpt draft

tosquash: add code blocks

* fix: manual edits

~L34 14:25
~L126 16:52
~L224 17:00
~L335 17:11
~EOF 17:18

* fix: self-correction

* amend grammar, phrasing

* docs: add new entry to _toctree.yml

* fix: use terms from glossary

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

---------

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
…ingface#25679)

* docs: ko: visual_question_answering.md

* feat: chatgpt draft

tosquash: add code blocks

* fix: manual edits

~L34 14:25
~L126 16:52
~L224 17:00
~L335 17:11
~EOF 17:18

* fix: self-correction

* amend grammar, phrasing

* docs: add new entry to _toctree.yml

* fix: use terms from glossary

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>

---------

Co-authored-by: SeongWooChoi <46990061+nuatmochoi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants