Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringify config #25637

Merged
merged 2 commits into from
Aug 22, 2023
Merged

stringify config #25637

merged 2 commits into from
Aug 22, 2023

Conversation

AleksanderWWW
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Raalsky who contributed this code.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@Raalsky
Copy link
Contributor

Raalsky commented Aug 22, 2023

LGTM 🚀

@sgugger
Copy link
Collaborator

sgugger commented Aug 22, 2023

@AleksanderWWW can you put your PR out of draft mode so we can merge it?

@AleksanderWWW AleksanderWWW marked this pull request as ready for review August 22, 2023 13:46
@AleksanderWWW
Copy link
Contributor Author

@sgugger Done :)

@sgugger sgugger merged commit 908f853 into huggingface:main Aug 22, 2023
3 checks passed
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* stringify config

* apply code formatting
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* stringify config

* apply code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants