fix peft ckpts not being pushed to hub #24578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
save_stepsandpush_to_hub=True, PEFT ckpts aren't being pushed to hub.Reason:
every
save_steps, the ckpts are being written to localcheckpoint-xxfolders. Now, in the trainer's function_push_from_checkpoint, it will copy the model files from the latest ckpt foldercheckpoint-xxto theoutput_dirwhich gets pushed to the Hub. Note that the modeling_files doesn't haveADAPTER_WEIGHTS_NAMEorADAPTER_SAFE_WEIGHTS_NAMEorADAPTER_CONFIG_NAMEleading to them not being pushed.This PR fixes it.
cc @younesbelkada